domains / software-engineering / code-review / code-review-excellence

code-review-excellence

Skill card

combined

The first two copies are nearly identical, with the second adding a generic Limitations section. The third copy is a much more detailed, structured procedure (phases, checklists, techniques) that the first two lack. The first two lack the detailed steps in the third, and the third lacks the specific 'Do not use' and 'Output Format' sections of the first two. Combining is necessary to capture the full scope of the skill as represented by the different versions.

Repositories

Other copies

Combined skill

---
name: code-review-excellence
description: Master effective code review practices to provide constructive feedback, catch bugs early, and foster knowledge sharing while maintaining team morale. Use when reviewing pull requests, establishing review standards, or mentoring developers.
---

# Code Review Excellence

Transform code reviews from gatekeeping to knowledge sharing through constructive feedback, systematic analysis, and collaborative improvement.

## Use this skill when

- Reviewing pull requests and code changes
- Establishing code review standards
- Mentoring developers through review feedback
- Auditing for correctness, security, or performance

## Do not use this skill when

- There are no code changes to review
- The task is a design-only discussion without code
- You need to implement fixes instead of reviewing

## Instructions

- Read context, requirements, and test signals first.
- Review for correctness, security, performance, and maintainability.
- Provide actionable feedback with severity and rationale.
- Ask clarifying questions when intent is unclear.
- If detailed checklists are required, open `resources/implementation-playbook.md`.

## Review Process

### Phase 1: Context Gathering
- Read PR description and linked issue.
- Check PR size and CI/CD status.
- Understand the business requirement.

### Phase 2: High-Level Review
- Evaluate architecture and design fit.
- Check file organization and testing strategy.

### Phase 3: Line-by-Line Review
- Check logic, security, performance, and maintainability.
- Use checklists for security, performance, and testing.

### Phase 4: Summary & Decision
- Summarize key concerns and highlights.
- Make a clear decision (Approve, Comment, Request Changes).

## Output Format

- High-level summary of findings
- Issues grouped by severity (blocking, important, minor)
- Suggestions and questions
- Test and coverage notes

## Resources

- `resources/implementation-playbook.md` for detailed review patterns and templates.

## Limitations
- Use this skill only when the task clearly matches the scope described above.
- Do not treat the output as a substitute for environment-specific validation, testing, or expert review.
- Stop and ask for clarification if required inputs, permissions, safety boundaries, or success criteria are missing.